[DASH] Make DASH vnet orch bulk logic consistent #3554
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lawrence Lee <lawlee@microsoft.com>
|
/azp run |
theasianpianist
requested review from
prabhataravind and
Yakiv-Huryk
and removed request for
prsunny
|
Azure Pipelines successfully started running 1 pipeline(s). |
orchagent/dash/dashvnetorch.cpp
Outdated
| @@ -430,7 +430,7 @@ bool DashVnetOrch::addVnetMap(const string& key, VnetMapBulkContext& ctxt) | |||
| SWSS_LOG_INFO("Not creating VNET map for %s since VNET %s doesn't exist", key.c_str(), ctxt.vnet_name.c_str()); | |||
| return false; | |||
| } | |||
| return addOutboundCaToPa(key, ctxt) && addPaValidation(key, ctxt); | |||
| return addOutboundCaToPa(key, ctxt) || addPaValidation(key, ctxt); | |||
There was a problem hiding this comment.
I think this should still be "AND" and not "OR".
If let's say addPaValidation returns true and addOutboundCaToPa returns false, we don't want the entry to be removed from the consumer.
Signed-off-by: Lawrence Lee <lawlee@microsoft.com>
|
/azp run |
|
Azure Pipelines will not run the associated pipelines, because the pull request was updated after the run command was issued. Review the pull request again and issue a new run command. |
Signed-off-by: Lawrence Lee <lawlee@microsoft.com>
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Why I did it
Fixes #3349
How I verified it
Details if related